kl0u commented on a change in pull request #7324: [FLINK-10596][cep] Added
access to timer service in IterativeCondition
URL: https://github.com/apache/flink/pull/7324#discussion_r245608873
##########
File path:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java
##########
@@ -555,17 +534,20 @@ public void close() throws Exception {
* @param sharedBufferAccessor The accessor to shared buffer that we
need to change
* @param computationState Current computation state
* @param event Current event which is processed
- * @param timestamp Timestamp of the current event
+ * @param timerService timer service which provides access to time
related features
* @return Collection of computation states which result from the
current one
* @throws Exception Thrown if the system cannot access the state.
*/
private Collection<ComputationState> computeNextStates(
final SharedBufferAccessor<T> sharedBufferAccessor,
final ComputationState computationState,
final EventWrapper event,
- final long timestamp) throws Exception {
+ final CepTimerService timerService) throws Exception {
- final ConditionContext<T> context = new
ConditionContext<>(this, sharedBufferAccessor, computationState);
+ final ConditionContext context = new
ConditionContext(sharedBufferAccessor,
Review comment:
Move argument to new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services