kl0u commented on a change in pull request #7324: [FLINK-10596][cep] Added access to timer service in IterativeCondition URL: https://github.com/apache/flink/pull/7324#discussion_r245613752
########## File path: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAIterativeConditionTimerContextTest.java ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cep.nfa; + +import org.apache.flink.cep.Event; +import org.apache.flink.cep.pattern.Pattern; +import org.apache.flink.cep.pattern.conditions.IterativeCondition; +import org.apache.flink.cep.utils.NFATestHarness; +import org.apache.flink.cep.utils.TestCepTimerService; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.apache.flink.util.TestLogger; + +import org.junit.Assert; +import org.junit.Test; + +import java.util.Collections; +import java.util.List; + +import static org.apache.flink.cep.utils.EventBuilder.event; +import static org.apache.flink.cep.utils.NFATestHarness.forPattern; +import static org.apache.flink.cep.utils.NFATestUtilities.compareMaps; +import static org.hamcrest.Matchers.is; +import static org.hamcrest.Matchers.nullValue; + +/** + * Tests for accesing time properties from {@link IterativeCondition}. + */ +public class NFAIterativeConditionTimerContextTest extends TestLogger { + Review comment: The first and second tests are the same. They only differ on the `isProcessingTime` flag and the `IterativeCondition` which is verifying the result. Why not extracting the common logic in a helper method with the arguments including 1) the flag, 2) the `Pattern` (not only the condition) and 3) the timestamp of the event. This will still allow the tests to be readable although not so verbose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
