tweise commented on a change in pull request #6760: [FLINK-10422] Follow AWS
specs in Kinesis Consumer
URL: https://github.com/apache/flink/pull/6760#discussion_r245701984
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -454,18 +453,6 @@ private ListShardsResult listShards(String streamName,
@Nullable String startSha
}
}
}
- // Kinesalite (mock implementation of Kinesis) does not
correctly exclude shards before
Review comment:
I don't think we can remove this until the issue in Kinesalite has been
actually fixed. Kinesalte is commonly used for testing and this change would be
breaking users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
