tweise commented on a change in pull request #6760: [FLINK-10422] Follow AWS 
specs in Kinesis Consumer
URL: https://github.com/apache/flink/pull/6760#discussion_r245740267
 
 

 ##########
 File path: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
 ##########
 @@ -454,18 +453,6 @@ private ListShardsResult listShards(String streamName, 
@Nullable String startSha
                                }
                        }
                }
-               // Kinesalite (mock implementation of Kinesis) does not 
correctly exclude shards before
 
 Review comment:
   Do you have an alternative in mind that does require access to an AWS 
account? We use Kinesalite for end-to-end testing and it has been quite helpful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to