tweise commented on a change in pull request #6760: [FLINK-10422] Follow AWS
specs in Kinesis Consumer
URL: https://github.com/apache/flink/pull/6760#discussion_r247595689
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -454,18 +453,6 @@ private ListShardsResult listShards(String streamName,
@Nullable String startSha
}
}
}
- // Kinesalite (mock implementation of Kinesis) does not
correctly exclude shards before
Review comment:
Testability is important, and Kinesalite is the only practical way for
integration / e2e testing without AWS account dependency that I know of. So I
would suggest we look for a solution to bring your work to the finish line w/o
compromising test support.
I would suggest we give it couple weeks and maybe few pings more for the
Kinesalite change to me merged. If not, then let's work on merging that change
into the Lyft fork: https://github.com/lyft/kinesalite
Then make sure a container is available with these changes that does not
leave users stranded, before updating Flink with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
