tillrohrmann commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum failed TMs in YarnResourceManager
URL: https://github.com/apache/flink/pull/7356#discussion_r250556244
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -94,6 +95,9 @@
* Container ID generation may vary across Hadoop versions. */
private static final String ENV_FLINK_CONTAINER_ID =
"_FLINK_CONTAINER_ID";
+ /** The default initial number of task manager. **/
+ private static final String DEFAULT_INITIAL_NUM_TASK_MANAGER = "2";
Review comment:
default values should be configured on the actual `ConfigOption`. So please
remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services