tillrohrmann commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum failed TMs in YarnResourceManager
URL: https://github.com/apache/flink/pull/7356#discussion_r250553467
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -145,6 +147,12 @@
/** All registered listeners for status updates of the ResourceManager.
*/
private ConcurrentMap<String, InfoMessageListenerRpcGateway>
infoMessageListeners;
+ /** The number of failed containers since the master became active. */
+ protected AtomicInteger failedContainerSoFar = new AtomicInteger(0);
+
+ /** Number of failed TaskManager containers before stopping the
application. Default is Integer.MAX_VALUE */
+ protected int maximumAllowedTaskManagerFailureCount = Integer.MAX_VALUE;
Review comment:
I would suggest to deactivate this by default by either setting it to `-1`
or use an `Optional`. By setting it to `Integer.MAX_VALUE` it will still
eventually terminate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
