tillrohrmann commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum failed TMs in YarnResourceManager
URL: https://github.com/apache/flink/pull/7356#discussion_r250558861
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -308,9 +313,9 @@ protected void runAsync(final Runnable runnable) {
highAvailabilityServices.setResourceManagerLeaderElectionService(rmLeaderElectionService);
heartbeatServices = new
TestingHeartbeatServices(5L, 5L, scheduledExecutor);
metricRegistry = NoOpMetricRegistry.INSTANCE;
- slotManager = new SlotManager(
+ slotManager = spy(new SlotManager(
Review comment:
If possible, we should avoid spying and mocking. It is better to explicitly
create testing objects instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
