StefanRRichter commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r250981665
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -884,15 +907,15 @@ public void scheduleForExecution() throws JobException {
if (state == JobStatus.RUNNING &&
currentGlobalModVersion == globalModVersion) {
schedulingFuture = newSchedulingFuture;
-
- newSchedulingFuture.whenCompleteAsync(
+ FutureUtils.whenCompleteAsyncIfNotDone(
+ newSchedulingFuture,
Review comment:
Mhh, the code was a straight transformation from the previously existing
code, but I think you are right and we are no longer required to sync back to
main thread here now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
