StefanRRichter commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r250988031
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -1014,7 +1014,6 @@ public void notifyAllocationFailure(AllocationID
allocationID, Exception cause)
//-- job starting and stopping
-----------------------------------------------------------------
private Acknowledge startJobExecution(JobMasterId newJobMasterId)
throws Exception {
- validateRunsInMainThread();
Review comment:
I removed it because the check failed because the man thread executor is
only set after receiveing the fencing token, in `startJobMasterServices()`. I
think now it would no longer cause problems as we have the dummy executor in
place, however I think there is limited value anyways because, again, we are
checking right at the start of `resetAndScheduleExecutionGraph`, the relevat
method vere because it interacts with the EG.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
