StefanRRichter commented on a change in pull request #7568: [FLINK-11417] Make
access to ExecutionGraph single threaded from JobMaster main thread
URL: https://github.com/apache/flink/pull/7568#discussion_r250989995
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/LogicalSlot.java
##########
@@ -152,7 +157,14 @@ public void fail(Throwable cause) {
*
* @param cause of the failure
*/
- void fail(Throwable cause);
+ void failAsync(Throwable cause);
+
+ /**
+ * Fail the payload with the given cause.
+ *
+ * @param cause of the failure
+ */
+ void failSync(Throwable cause);
Review comment:
You mean I comment on the `failAsync`instead I guess? because that is the
one we will always use later once the slot pool also runs in the JM main thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
