Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37978039
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java
---
@@ -170,4 +170,43 @@ public void initializeOnMaster(ClassLoader loader)
throws Exception {
fail(e.getMessage());
}
}
+
+ /**
+ * Verifies failure when the client and job manager versions mismatch
+ */
+ @Test
+ public void testFailureClientJobManagerVersionMismatch() {
+ try {
+ // create a simple job graph
+
+ JobVertex jobVertex = new JobVertex("Vertex that fails
in initializeOnMaster") {
+
+ @Override
+ public void initializeOnMaster(ClassLoader
loader) throws Exception {
+ throw new RuntimeException("test
exception");
--- End diff --
Why using a faulty `JobVertex` here. This might also be the reason for the
"expected" `JobExecutionException` then. And you don't check properly whether
that's not the cause for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
