Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/945#discussion_r37981839
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
    @@ -205,7 +205,7 @@ public static void submitJobDetached(
                Preconditions.checkNotNull(timeout, "The timeout must not be 
null.");
     
                Future<Object> future = jobManagerGateway.ask(
    -                           new JobManagerMessages.SubmitJob(jobGraph, 
false),
    +                           new JobManagerMessages.SubmitJob(jobGraph, 
false, jobGraph.getClientVersion()),
    --- End diff --
    
    Why don't you simply use the `getImplementationVersion` of the `JobClient` 
but the version of the `Configuration` which is part of the `jobGraph` instance?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to