Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-135026427
I had some comments concerning the implementation. I think as a first step
we should not check whether the JM and TM have the same versions because in
nearly all cases both classes will be started from the same binaries. If we
should decide at a later point that we want to check that all used actors are
compatible, then I would vote for using the decoration mechanism to
transparently add a version ID instead of adding it manually to a subset of
messages. The latter approach is IMO error-prone.
Checking whether the client and the JM have compatible versions should be
sufficient. I'm not quite sure whether
`getClass().getPackage().getImplementationVersion()` is the right way to go
here. Using this function won't allow compatible versions which only differ in
a minor version number to work together. IMHO, this should be allowed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
