Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37989216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -694,6 +695,18 @@ public void cancel() {
}
}
+ public void stop() {
+ if(jobType == JobType.STREAMING) {
+ for(ExecutionVertex ev :
this.getAllExecutionVertices()) {
+ if(ev.getNumberOfInputs() == 0) { // send
signal to sources only
+ ev.stop();
+ }
+ }
+ return;
+ }
+ throw new RuntimeException("STOP is only supported by streaming
jobs.");
--- End diff --
I think it's better to write `if () {...} else { throw ... }`. This will
get rid off the disrupted control flow here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
