Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991061
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount/StormWordCountLocal.java
---
@@ -67,8 +67,10 @@ public static void main(final String[] args) throws
Exception {
Utils.sleep(10 * 1000);
- // TODO kill does no do anything so far
cluster.killTopology(topologyId);
+ // killing sends STOP signal, takes some time to clean up
+ Utils.sleep(1000);
--- End diff --
Unfortunately, we need to delay a little bit... I am not a fan of it
either. However, I rebase this PR multiple times and it was never an issue on
Travis (according test stability). If you don't have strong objection against
it, I would leave it. (The main cause of the problem comes from Storm behavior
we mimic here. `killTopology(...)` does not block in Storm, so we do not block
here either.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
