[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713590#comment-14713590
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991329
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -536,6 +541,68 @@ public int compare(JobStatusMessage o1,
JobStatusMessage o2) {
}
/**
+ * Executes the STOP action.
+ *
+ * @param args Command line arguments for the stop action.
+ */
+ protected int stop(String[] args) {
+ LOG.info("Running 'stop' command.");
+
+ StopOptions options;
+ try {
+ options = CliFrontendParser.parseStopCommand(args);
+ } catch (CliArgsException e) {
+ return handleArgException(e);
+ } catch (Throwable t) {
+ return handleError(t);
+ }
+
+ // evaluate help flag
+ if (options.isPrintHelp()) {
+ CliFrontendParser.printHelpForStop();
+ return 0;
+ }
+
+ String[] stopArgs = options.getArgs();
+ JobID jobId;
+
+ if (stopArgs.length > 0) {
+ String jobIdString = stopArgs[0];
+ try {
+ jobId = new
JobID(StringUtils.hexStringToByte(jobIdString));
+ } catch (Exception e) {
+ LOG.error("Error: The value for the Job ID is
not a valid ID.");
+ System.out.println("Error: The value for the
Job ID is not a valid ID.");
+ return 1;
+ }
+ } else {
+ LOG.error("Missing JobID in the command line
arguments.");
+ System.out.println("Error: Specify a Job ID to stop a
job.");
+ return 1;
+ }
+
+ try {
+ ActorGateway jobManager = getJobManagerGateway(options);
+ Future<Object> response = jobManager.ask(new
StopJob(jobId), askTimeout);
+
+ try {
+ Await.result(response, askTimeout);
+
+ Object rc = response.value().get().get();
+ if(rc instanceof StoppingFailure) {
+ throw ((StoppingFailure)rc).cause();
+ }
+
+ return 0;
+ } catch (Exception e) {
+ throw new Exception("Stopping the job with ID "
+ jobId + " failed.", e);
+ }
+ } catch (Throwable t) {
--- End diff --
I agree, thus the logical consequence would be to change all of them.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
