[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713592#comment-14713592
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r37991348
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/test/java/org/apache/flink/stormcompatibility/api/FlinkTestCluster.java
---
@@ -46,15 +52,24 @@ public void submitTopologyWithOpts(final String
topologyName, final Map<?, ?> co
final SubmitOptions submitOpts)
throws Exception {
final TestStreamEnvironment env = (TestStreamEnvironment)
StreamExecutionEnvironment.getExecutionEnvironment();
- env.start(topology.getStreamGraph().getJobGraph(topologyName));
+
+ JobGraph jobGraph =
topology.getStreamGraph().getJobGraph(topologyName);
+ this.jobIdBuffer.put(topologyName, jobGraph.getJobID());
+
+ env.start(jobGraph);
}
@Override
public void killTopology(final String topologyName) {
+ this.killTopologyWithOpts(topologyName, null);
}
@Override
public void killTopologyWithOpts(final String name, final KillOptions
options) {
+ // TODO: consider options
--- End diff --
Considering options will be new feature... `KillOptions` are not supported
yet. Comment for future reference only. Not related to this PR.
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
