StefanRRichter commented on a change in pull request #7674: [FLINK-10043]
[State Backends] Refactor RocksDBKeyedStateBackend object
construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#discussion_r255936614
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/BackendRestorerProcedure.java
##########
@@ -141,7 +140,7 @@ public T createAndRestore(@Nonnull List<? extends
Collection<S>> restoreOptions)
private T attemptCreateAndRestore(Collection<S> restoreState) throws
Exception {
// create a new, empty backend.
- final T backendInstance = instanceSupplier.get();
+ final T backendInstance = instanceSupplier.get(restoreState);
Review comment:
As mentioned in an earlier comment, I think it would be better if this would
already give us a fully setup and restored backend. There should be no need to
have a separate restore method that is always called just a few liens below
anyways. I would connect backend setup and restoring in the builder, then we
also don't need to split up restoring between incremental and full state in two
steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
