StefanRRichter commented on a change in pull request #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code URL: https://github.com/apache/flink/pull/7674#discussion_r255973771
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendBuilder.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state; + +import java.io.IOException; +import java.util.Collection; + +/** + * A mutable builder to build a state backend instance + * + * @param <T> The type of the state backend instance + * @param <S> The type of the state handle + */ +public interface StateBackendBuilder<T, S> { + T build() throws IOException; + + StateBackendBuilder setRestoreStateHandles(Collection<S> restoreStateHandles); Review comment: I think this is not required to be part of the interface. When I look at the usage, the state handles could simply be supplied to the constructor of the `StateBackendBuilder` implementation. This make sense if there are backends in the future that might restore differently than with state handles (e.g. one of those you are working on). Furthermore, then I wonder if this is even needed or we could just `SupplierWithException` as the root interface. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
