TisonKun commented on issue #6883: [FLINK-10610] [tests] Port slot sharing cases to new codebase URL: https://github.com/apache/flink/pull/6883#issuecomment-463116842 @tillrohrmann thanks for your guide. Now I see the reason that slot sharing isn't really tested and approve that we should only port `CoLocationConstraintITCase`. I've moved to #7690 and find that even we don't have code below we can pass the test. Maybe we can set a CountDownLatch like this pr does? ```java final SlotSharingGroup slotSharingGroup = new SlotSharingGroup(); receiver.setSlotSharingGroup(slotSharingGroup); sender.setSlotSharingGroup(slotSharingGroup); receiver.setStrictlyCoLocatedWith(sender); ``` basically it's OK to me that we close this thread and move discussions to #7689 #7690 and #7676
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
