StefanRRichter commented on a change in pull request #7711:
[FLINK-11618][state] Refactor operator state repartition mechanism
URL: https://github.com/apache/flink/pull/7711#discussion_r257263753
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
##########
@@ -328,24 +330,25 @@ private void reDistributePartitionableStates(
checkState(newOperatorIDs.size() == oldOperatorStates.size(),
"This method still depends on the order of the new and
old operators");
- //collect the old partitionable state
- List<List<OperatorStateHandle>> oldManagedOperatorStates = new
ArrayList<>(oldOperatorStates.size());
- List<List<OperatorStateHandle>> oldRawOperatorStates = new
ArrayList<>(oldOperatorStates.size());
+ List<List<List<OperatorStateHandle>>> oldManagedOperatorStates
= new ArrayList<>(oldOperatorStates.size());
Review comment:
Maybe a comment would be helpful what the meaning of each nested level of
list is, e.g. operator -> subtask -> ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
