zentol commented on a change in pull request #7717: [FLINK-11533] [container]
Add option parse JAR manifest for jobClassName
URL: https://github.com/apache/flink/pull/7717#discussion_r258429247
##########
File path:
flink-container/src/test/java/org/apache/flink/container/entrypoint/TestJob.java
##########
@@ -39,4 +42,20 @@ public static void main(String[] args) throws Exception {
ParameterTool parameterTool = ParameterTool.fromArgs(args);
env.execute(TestJob.class.getCanonicalName() + "-" +
parameterTool.getRequired("arg"));
}
+
+ /**
+ * Returns the test jar including {@link TestJob} (see pom.xml and
assembly/test-assembly.xml).
+ *
+ * @return Test jar file
+ * @throws FileNotFoundException If test-jar has not been build
Review comment:
`if test-jar could not be found`; there are some subtle/weird things about
working directories when running tests, so I wouldn't go so far as to speculate
why the jar couldn't be found
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
