zentol commented on a change in pull request #7717: [FLINK-11533] [container]
Add option parse JAR manifest for jobClassName
URL: https://github.com/apache/flink/pull/7717#discussion_r258845960
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/ClassPathJobGraphRetriever.java
##########
@@ -67,10 +67,10 @@
private final String[] programArguments;
ClassPathJobGraphRetriever(
- @Nonnull String jobClassName,
- @Nonnull JobID jobId,
Review comment:
revert the indentation change. The extra indentation better separates the
arguments from the method body. I know we don't have actual rules for this;
it's more a convention that is slowly being introduced...
In any case this is an unrelated formatting change tho :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
