zentol commented on a change in pull request #7717: [FLINK-11533] [container]
Add option parse JAR manifest for jobClassName
URL: https://github.com/apache/flink/pull/7717#discussion_r260726736
##########
File path: flink-container/pom.xml
##########
@@ -66,4 +66,64 @@ under the License.
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <!-- Assemble a test jar for EntryClassParserTest. More
information on this:
+
http://stackoverflow.com/questions/1401857/using-maven-to-build-separate-jar-files-for-unit-testing-a-custom-class-loader
+ -->
+ <plugin>
+ <artifactId>maven-assembly-plugin</artifactId>
Review comment:
you could simplify this a lof by using the `shade-plugin`; you wouldn't need
a separate `assembly.xml`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
