tillrohrmann commented on a change in pull request #7356: 
[FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#discussion_r258466657
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
 ##########
 @@ -55,6 +55,18 @@
                        " default, the port of the JobManager, because the same 
ActorSystem is used." +
                        " Its not possible to use this configuration key to 
define port ranges.");
 
+       /**
+        * Defines the maximum number of workers (YARN / Mesos) failure can 
happen in a minute.
 
 Review comment:
   Do we want to define the rate per minute? If we define it per hour, it would 
be possible to define lower rates. The downside would be that it takes longer 
until you fall below the maximum threshold again/recover. Maybe it would be 
good to make this controllable (contradicting my initial comments because you 
had it like this). What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to