tillrohrmann commented on a change in pull request #7356: 
[FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#discussion_r258481057
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
 ##########
 @@ -83,8 +83,8 @@
         */
        public static final ConfigOption<String> MAX_FAILED_CONTAINERS =
                key("yarn.maximum-failed-containers")
-               .noDefaultValue()
-               .withDescription("Maximum number of containers the system is 
going to reallocate in case of a failure.");
+                       .noDefaultValue()
+                       .withDescription("Maximum number of containers the 
system is going to reallocate in case of a failure.");
 
 Review comment:
   I would suggest to revert this change and rather put `key` on the same line 
as `MAX_FAILED_CONTAINERS`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to