tillrohrmann commented on a change in pull request #7356:
[FLINK-10868][flink-yarn] Enforce maximum TMs failure rate in ResourceManagers
URL: https://github.com/apache/flink/pull/7356#discussion_r258468197
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerFactory.java
##########
@@ -97,6 +104,8 @@ public MesosResourceManagerFactory(@Nonnull MesosServices
mesosServices, @Nonnul
taskManagerParameters,
taskManagerContainerSpec,
webInterfaceUrl,
- jobManagerMetricGroup);
+ jobManagerMetricGroup,
+ new TimestampBasedFailureRater(failureRate, Time.of(1,
TimeUnit.MINUTES))
Review comment:
I think it would be good to have `NoFailureRater` implementation which is
instantiated if `failureRate == -1`. We could put the instantiation logic into
a helper method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
