[ 
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718306#comment-14718306
 ] 

ASF GitHub Bot commented on FLINK-2111:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38186444
  
    --- Diff: 
flink-clients/src/test/java/org/apache/flink/client/CliFrontendInfoTest.java ---
    @@ -107,28 +89,28 @@ public InfoTestCliFrontend(int expectedDop) throws 
Exception {
                @Override
                protected Client getClient(CommandLineOptions options, 
ClassLoader loader, String programName, int par)
                                throws Exception
    -           {
    +                           {
                        return new TestClient(expectedDop);
    -           }
    +                           }
        }
    -   
    +
        private static final class TestClient extends Client {
    -           
    +
                private final int expectedDop;
    -           
    +
                private TestClient(int expectedDop) throws Exception {
                        super(new InetSocketAddress(InetAddress.getLocalHost(), 
6176),
                                        new Configuration(), 
CliFrontendInfoTest.class.getClassLoader(), -1);
    -                   
    +
                        this.expectedDop = expectedDop;
                }
    -           
    +
                @Override
                public String getOptimizedPlanAsJson(PackagedProgram prog, int 
parallelism)
                                throws CompilerException, 
ProgramInvocationException
    -           {
    +                           {
    --- End diff --
    
    Same here with the indentation. But might also be a Github rendering 
problem.


> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
>                 Key: FLINK-2111
>                 URL: https://issues.apache.org/jira/browse/FLINK-2111
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime, JobManager, Local Runtime, 
> Streaming, TaskManager, Webfrontend
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is 
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks 
> such that the sources can stop emitting data and shutdown cleanly, resulting 
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for 
> https://issues.apache.org/jira/browse/FLINK-1929



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to