[ 
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718320#comment-14718320
 ] 

ASF GitHub Bot commented on FLINK-2111:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r38187428
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/web/JobManagerInfoServlet.java
 ---
    @@ -220,6 +222,30 @@ else if("cancel".equals(req.getParameter("get"))) {
     
                                Await.ready(response, timeout);
                        }
    +                   else if ("stop".equals(req.getParameter("get"))) {
    +                           String jobId = req.getParameter("job");
    +
    +                           response = jobmanager.ask(
    +                                           new 
StopJob(JobID.fromHexString(jobId)),
    +                                           timeout);
    +
    +                           Await.ready(response, timeout);
    +
    +                           String status = "success";
    +                           String cause = "";
    +
    +                           Object rc = response.value().get().get();
    --- End diff --
    
    We could use a `Await.result` if you're interested in the return value of 
the `Future`.


> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
>                 Key: FLINK-2111
>                 URL: https://issues.apache.org/jira/browse/FLINK-2111
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime, JobManager, Local Runtime, 
> Streaming, TaskManager, Webfrontend
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is 
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks 
> such that the sources can stop emitting data and shutdown cleanly, resulting 
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for 
> https://issues.apache.org/jira/browse/FLINK-1929



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to