[
https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718384#comment-14718384
]
ASF GitHub Bot commented on FLINK-2111:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r38191638
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendAddressConfigurationTest.java
---
@@ -45,163 +43,122 @@
@Rule
public TemporaryFolder folder = new TemporaryFolder();
-
+
@BeforeClass
public static void init() {
CliFrontendTestUtils.pipeSystemOutToNull();
}
-
+
@Before
- public void clearConfig() {
+ public void clearConfig() throws Exception {
CliFrontendTestUtils.clearGlobalConfiguration();
}
@Test
- public void testInvalidConfigAndNoOption() {
+ public void testInvalidConfigAndNoOption() throws Exception {
+ CliFrontend frontend = new
CliFrontend(CliFrontendTestUtils.getInvalidConfigDir());
+ CommandLineOptions options = mock(CommandLineOptions.class);
+
try {
- CliFrontend frontend = new
CliFrontend(CliFrontendTestUtils.getInvalidConfigDir());
- CommandLineOptions options =
mock(CommandLineOptions.class);
-
- try {
- frontend.getJobManagerAddress(options);
- fail("we expect an exception here because the
we have no config");
- }
- catch (Exception e) {
- // expected
- }
+ frontend.getJobManagerAddress(options);
+ fail("we expect an exception here because the we have
no config");
}
catch (Exception e) {
- e.printStackTrace();
- fail(e.getMessage());
+ // expected
--- End diff --
We cannot. The expected exception is an `Exception` instance. And the
constructor of `CliFrontend` might throw an exception, too. We cannot
distinguish between both...
> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
> Key: FLINK-2111
> URL: https://issues.apache.org/jira/browse/FLINK-2111
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime, JobManager, Local Runtime,
> Streaming, TaskManager, Webfrontend
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is
> a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks
> such that the sources can stop emitting data and shutdown cleanly, resulting
> in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for
> https://issues.apache.org/jira/browse/FLINK-1929
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
