twalthr commented on a change in pull request #8018: [FLINK-11884][table]
Separate creation and validation of LogicalNodes from TableImpl
URL: https://github.com/apache/flink/pull/8018#discussion_r269489606
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
##########
@@ -502,7 +455,8 @@ class GroupedTableImpl(
private def selectInternal(fields: Seq[Expression]): Table = {
val expressionsWithResolvedCalls =
fields.map(_.accept(tableImpl.callResolver)).asJava
- val extracted =
extractAggregationsAndProperties(expressionsWithResolvedCalls,
tableImpl.getUniqueAttributeSupplier)
+ val extracted =
extractAggregationsAndProperties(expressionsWithResolvedCalls,
Review comment:
nit: one line per argument whenever it does not fit into a line makes the
code more readable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
