twalthr commented on a change in pull request #8018: [FLINK-11884][table]
Separate creation and validation of LogicalNodes from TableImpl
URL: https://github.com/apache/flink/pull/8018#discussion_r269487548
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
##########
@@ -133,61 +118,40 @@ class TableImpl(
ExpressionParser.parseExpression(primaryKey))
}
- override def createTemporalTableFunction(
- timeAttribute: Expression,
- primaryKey: Expression)
- : TemporalTableFunction = {
- createTemporalTableFunctionInternal(
- expressionBridge.bridge(timeAttribute),
- expressionBridge.bridge(primaryKey))
+ def createTemporalTableFunction(
+ timeAttribute: Expression,
+ primaryKey: Expression)
+ : TemporalTableFunction = {
+ operationTreeBuilder.createTemporalTableFunction(
+ timeAttribute,
+ primaryKey,
+ logicalPlan)
}
- private def createTemporalTableFunctionInternal(
- timeAttribute: PlannerExpression,
- primaryKey: PlannerExpression)
- : TemporalTableFunction = {
- val temporalTable = TemporalTable(timeAttribute, primaryKey, logicalPlan)
- .validate(tableEnv)
- .asInstanceOf[TemporalTable]
-
- TemporalTableFunctionImpl.create(
Review comment:
Creating a temporal table function is unrelated to Operation, right? We
should think about keeping the logic here, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
