twalthr commented on a change in pull request #8018: [FLINK-11884][table]
Separate creation and validation of LogicalNodes from TableImpl
URL: https://github.com/apache/flink/pull/8018#discussion_r269482745
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
##########
@@ -111,9 +112,11 @@ abstract class TableEnvironment(val config: TableConfig) {
private val externalCatalogs = new mutable.HashMap[String, ExternalCatalog]
// temporary bridge between API and planner
- private[flink] val expressionBridge: ExpressionBridge[PlannerExpression] =
+ protected val expressionBridge: ExpressionBridge[PlannerExpression] =
new ExpressionBridge[PlannerExpression](functionCatalog,
PlannerExpressionConverter.INSTANCE)
+ private[flink] val operationTreeBuilder = new OperationTreeBuilder(this)
Review comment:
comment: we should definitely reduce the dependency of
`OperationTreeBuilder` in the future. It should not be necessary to pass the
entire `TableEnvironment` API class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
