hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add
column operations for TableApi
URL: https://github.com/apache/flink/pull/8087#discussion_r274752419
##########
File path: docs/dev/table/functions.md
##########
@@ -5800,3 +5800,284 @@ For Table API, please use `_` for spaces (e.g.,
`DAY_TO_HOUR`).
| | `SQL_TSI_SECOND ` _(SQL-only)_ |
{% top %}
+
+Column Operations
Review comment:
Both Functions and Expressions make sense here. The columns() method is an
Expression and also a Function. However, if we decided to put this method in
`Built-In Functions`, naming it column Functions may be more consistent with
the title?
Another reason is when we look at the syntax of the column method:
```
columnFunction:
[-]columns(columnExprs)
columnExprs:
columnExpr [, columnExpr]*
columnExpr:
columnRef | columnIndex to columnIndex | columnName to columnName
columnRef:
columnName(The field name that exists in the table) | columnIndex(a
positive integer starting from 1)
```
we will find the column expression has already been used to indicate the
parameters of column method, i.e., columnExpr.
@dawidwys What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
