hequn8128 commented on a change in pull request #8087: [FLINK-12029][table] Add
column operations for TableApi
URL: https://github.com/apache/flink/pull/8087#discussion_r274773927
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala
##########
@@ -564,26 +575,47 @@ class WindowGroupedTableImpl(
fields)
}
+ private def expandColumnsInGroupWindow(window: GroupWindow): GroupWindow = {
Review comment:
The time filed in GroupWindow can also contains a column operation. For
example,
```
.window(Slide.over("3.milli").every("10.milli").on("columns(b)").as("w"))
```
And time field are passed to the `extractFieldReferences()`:
```
val projectFields = extractFieldReferences(
(expressionsWithResolvedCalls ++ resolvedGroupKeys :+
resolvedWindow.getTimeField))
```
if we don't expand column operations for time field,
`extractFieldReferences` would be failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
