zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster 
integration test under non-secure mode
URL: https://github.com/apache/flink/pull/8144#issuecomment-483088606
 
 
   @tillrohrmann I checked the `flink-yarn-tests` module, we have yarn test in 
non-secure mode. But the tricky thing is that we set 
`yarn.minicluster.fixed.ports` to `true` 
(https://github.com/apache/flink/blob/master/flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java#L169),
 so that JM can connect to Yarn RM without `yarn-site.xml`, because yarn RM 
will always use `8030` as the scheduler service port.
   But I don't think this is the correct way to do integration test.
   1. Using fixed port is easy to cause port conflicts in their local 
environment and it is hard for user to figure out why their test fail.
   2. It is impossible to start 2 MiniYarnCluster.
   3. It is hard for downstream project to follow this. We can not enforce the 
downstream project set `yarn.minicluster.fixed.ports` to `true` (The default 
value is `false`, so most of time user don't know he needs to set it to `true`)
   
   I will update the test code as well.
   
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to