azagrebin commented on a change in pull request #8191: [FLINK-12213][network]
Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276242526
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -281,20 +283,7 @@ public void
testShouldShutDownTaskManagerServicesInPostStop() throws Exception {
.setTaskStateManager(localStateStoresManager)
.build();
- final long heartbeatInterval = 1000L;
- final long heartbeatTimeout = 1000L;
- final HeartbeatServices heartbeatServices = new
HeartbeatServices(heartbeatInterval, heartbeatTimeout);
-
- final TaskExecutor taskManager = new TaskExecutor(
- rpc,
- taskManagerConfiguration,
- haServices,
- taskManagerServices,
- heartbeatServices,
-
UnregisteredMetricGroups.createUnregisteredTaskManagerMetricGroup(),
- null,
- dummyBlobCacheService,
- testingFatalErrorHandler);
+ final TaskExecutor taskManager =
createTaskExecutor(taskManagerServices);
Review comment:
NIce refactoring for TaskExecutor creation, could you move it into a
separate commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
