azagrebin commented on a change in pull request #8191: [FLINK-12213][network]
Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276572354
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -287,4 +311,8 @@ public boolean isShutdown() {
return isShutdown;
}
}
+
+ public static NetworkEnvironment build(NetworkEnvironmentConfiguration
configuration) {
Review comment:
If it is used only for tests, I would suggest to move to test packages. It
could be `NetworkEnvironmentConfigurationBuilder.buildNetworkEnvironment()` or
maybe we could just rename `NetworkEnvironmentConfigurationBuilder` to
`NetworkEnvironmentBuilder` if we do not need builder only for
`NetworkEnvironmentConfiguration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
