azagrebin commented on a change in pull request #8191: [FLINK-12213][network]
Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276571337
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -79,9 +90,21 @@ public NetworkEnvironment(NetworkEnvironmentConfiguration
config, TaskEventPubli
this.taskEventPublisher = checkNotNull(taskEventPublisher);
+ registerNetworkMetrics(parentMetricGroup);
+
isShutdown = false;
}
+ private void registerNetworkMetrics(ComponentMetricGroup
parentMetricGroup) {
Review comment:
As it is used in constructor, could we convert it into a static method:
`private static void registerNetworkMetrics(ComponentMetricGroup
parentMetricGroup, networkBufferPool)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
