azagrebin commented on a change in pull request #8191: [FLINK-12213][network]
Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276567441
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1369,18 +1256,8 @@ public void
testMaximumRegistrationDurationAfterConnectionLoss() throws Exceptio
configuration.setString(TaskManagerOptions.REGISTRATION_TIMEOUT, "100 ms");
final TaskSlotTable taskSlotTable = new
TaskSlotTable(Collections.singleton(ResourceProfile.UNKNOWN), timerService);
- final long heartbeatInterval = 10L;
final TaskManagerServices taskManagerServices = new
TaskManagerServicesBuilder().setTaskSlotTable(taskSlotTable).build();
- final TaskExecutor taskExecutor = new TaskExecutor(
- rpc,
-
TaskManagerConfiguration.fromConfiguration(configuration),
- haServices,
- taskManagerServices,
- new HeartbeatServices(heartbeatInterval, 10L),
-
UnregisteredMetricGroups.createUnregisteredTaskManagerMetricGroup(),
- null,
- dummyBlobCacheService,
- testingFatalErrorHandler);
+ final TaskExecutor taskExecutor =
createTaskExecutor(taskManagerServices);
Review comment:
here we had `new HeartbeatServices(10L, 10L)`, not `HEARTBEAT_SERVICES `,
should we keep it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
