zhijiangW commented on a change in pull request #8191: [FLINK-12213][network]
Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276706847
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1472,22 +1349,12 @@ public void testIgnoringSlotRequestsIfNotRegistered()
throws Exception {
*/
@Test
public void testReconnectionAttemptIfExplicitlyDisconnected() throws
Exception {
- final long heartbeatInterval = 1000L;
final TaskSlotTable taskSlotTable = new
TaskSlotTable(Collections.singleton(ResourceProfile.UNKNOWN), timerService);
final TaskManagerLocation taskManagerLocation = new
LocalTaskManagerLocation();
- final TaskExecutor taskExecutor = new TaskExecutor(
- rpc,
-
TaskManagerConfiguration.fromConfiguration(configuration),
- haServices,
- new TaskManagerServicesBuilder()
- .setTaskSlotTable(taskSlotTable)
- .setTaskManagerLocation(taskManagerLocation)
- .build(),
- new HeartbeatServices(heartbeatInterval, 1000L),
-
UnregisteredMetricGroups.createUnregisteredTaskManagerMetricGroup(),
- null,
- dummyBlobCacheService,
- testingFatalErrorHandler);
+ final TaskExecutor taskExecutor = createTaskExecutor(new
TaskManagerServicesBuilder()
Review comment:
I thought `HeartbeatServices` could be reused in the tests only if it needs
different internal and timeout in special tests. In this test the created new
`HeartbeatServices` is the same with `HEARTBEAT_SERVICES`, so I reuse the
static one. Referring some other previous tests, they also reuse the same
service. Do you have other concerns? @zentol
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
