zhijiangW commented on a change in pull request #8191: [FLINK-12213][network]
Pass TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r278070586
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1472,22 +1349,12 @@ public void testIgnoringSlotRequestsIfNotRegistered()
throws Exception {
*/
@Test
public void testReconnectionAttemptIfExplicitlyDisconnected() throws
Exception {
- final long heartbeatInterval = 1000L;
final TaskSlotTable taskSlotTable = new
TaskSlotTable(Collections.singleton(ResourceProfile.UNKNOWN), timerService);
final TaskManagerLocation taskManagerLocation = new
LocalTaskManagerLocation();
- final TaskExecutor taskExecutor = new TaskExecutor(
- rpc,
-
TaskManagerConfiguration.fromConfiguration(configuration),
- haServices,
- new TaskManagerServicesBuilder()
- .setTaskSlotTable(taskSlotTable)
- .setTaskManagerLocation(taskManagerLocation)
- .build(),
- new HeartbeatServices(heartbeatInterval, 1000L),
-
UnregisteredMetricGroups.createUnregisteredTaskManagerMetricGroup(),
- null,
- dummyBlobCacheService,
- testingFatalErrorHandler);
+ final TaskExecutor taskExecutor = createTaskExecutor(new
TaskManagerServicesBuilder()
Review comment:
Thanks for the explanation.
Ok, that makes sense to keep the same behavior during refactoring. Even
though it is not necessary to create a new heartbeat service as we thought, it
should be in a separate ticket for this issue, not involved in my changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
