twalthr commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r277623759
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/StreamTableEnvImpl.scala
##########
@@ -159,48 +159,13 @@ abstract class StreamTableEnvironment(
}
}
- /**
- * Creates a table source and/or table sink from a descriptor.
- *
- * Descriptors allow for declaring the communication to external systems in
an
- * implementation-agnostic way. The classpath is scanned for suitable table
factories that match
- * the desired configuration.
- *
- * The following example shows how to read from a Kafka connector using a
JSON format and
- * registering a table source "MyTable" in append mode:
- *
- * {{{
- *
- * tableEnv
- * .connect(
- * new Kafka()
- * .version("0.11")
- * .topic("clicks")
- * .property("zookeeper.connect", "localhost")
- * .property("group.id", "click-group")
- * .startFromEarliest())
- * .withFormat(
- * new Json()
- * .jsonSchema("{...}")
- * .failOnMissingField(false))
- * .withSchema(
- * new Schema()
- * .field("user-name", "VARCHAR").from("u_name")
- * .field("count", "DECIMAL")
- * .field("proc-time", "TIMESTAMP").proctime())
- * .inAppendMode()
- * .registerSource("MyTable")
- * }}}
- *
- * @param connectorDescriptor connector descriptor describing the external
system
- */
def connect(connectorDescriptor: ConnectorDescriptor): StreamTableDescriptor
= {
new StreamTableDescriptor(this, connectorDescriptor)
}
/**
Review comment:
Remove all comments that where defined in the interface. We don't need to
maintain consistency in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
