twalthr commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r278101861
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/factories/StreamTableSinkFactory.scala
##########
@@ -20,15 +20,15 @@ package org.apache.flink.table.factories
import java.util
-import org.apache.flink.table.sinks.StreamTableSink
+import org.apache.flink.table.sinks.{StreamTableSink, TableSink}
/**
* A factory to create configured table sink instances in a streaming
environment based on
- * string-based properties. See also [[TableFactory]] for more information.
+ * string-based properties. See also [[TableSinkFactory]] for more
information.
*
* @tparam T type of records that the factory consumes
*/
-trait StreamTableSinkFactory[T] extends TableFactory {
+trait StreamTableSinkFactory[T] extends TableSinkFactory[T] {
Review comment:
@wuchong yes I'm talking about FLIP-27. The new unified `SourceFunction`
should be in `flink-core` close to `MapFunction` etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
