twalthr commented on a change in pull request #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#discussion_r277725059
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetValues.scala ########## @@ -67,7 +67,7 @@ class DataSetValues( } override def translateToPlan( - tableEnv: BatchTableEnvironment, + tableEnv: BatchTableEnvImpl, Review comment: Totally agree. I thought we are only using `getConfig()`. We can postpone any bigger change here. This code will be dropped anyway soon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
