link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-486039068 Thanks for the review @tillrohrmann! To answer the first three questions: the `IllegalStateException` should be thrown by the following lines in 1.6.4, 1.7.2 and 1.8.0 respectively. https://github.com/apache/flink/blob/6f4148180ba372a2c12c1d54bea8579350af6c98/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java#L2568 https://github.com/apache/flink/blob/ceba8af39b28b91ae6f2d5cbdb1b99258a73e742/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java#L411 https://github.com/apache/flink/blob/4caec0d4bab497d7f9a8d9fec4680089117593df/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java#L410 > Independent of the question whether to store the data locally or not, I would like to understand where the problem comes from because the SnapshotDirectory seems to use the right FileSystem implementation to check the existence. Now we are using `SnapshotDirectory(Path)` to create the instance, which will infer its scheme from the Path URI, and get the corresponding `FileSystem` based on that. https://github.com/apache/flink/blob/4caec0d4bab497d7f9a8d9fec4680089117593df/flink-runtime/src/main/java/org/apache/flink/runtime/state/SnapshotDirectory.java#L66 If the scheme is missing in the URI, we get the default `FileSystem` which can be set by `fs.default-scheme`. https://github.com/apache/flink/blob/4caec0d4bab497d7f9a8d9fec4680089117593df/flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java#L334
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
