link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix 
RocksDBStateBackend's mistaken usage of default filesystem
URL: https://github.com/apache/flink/pull/8068#issuecomment-486217871
 
 
   Yes, it exists in the local filesystem, but `SnapshotDirectory#exists` will 
fallback to using the default `FileSystem` because the 
`SnapshotDirectory.directory` does not have the scheme part, hence it would 
always return false if the default `FileSystem` is set to another filesystem.
   
   I think using the file's absolute path to initiate a `Path` for 
`SnapshotDirectory` is an accidental mistake, and we see other usages of 
`SnapshotDirectory` is with the files' full URIs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to