link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix 
RocksDBStateBackend's mistaken usage of default filesystem
URL: https://github.com/apache/flink/pull/8068#issuecomment-486042889
 
 
   > Moreover, I was wondering whether `SnapshotDirectory.temporary` should 
always return a local `SnapshotDirectory`. If this should be the case, then one 
could change the signature to `SnapshotDirectory.temporary(File)` in order to 
avoid the wrong usage. Maybe @StefanRRichter could help to answer this question.
   
   IMHO, we should only use the local file system to store task local snapshots 
for efficiency and simplicity, and I'm not sure if Rocksdb can checkpoint to 
other file systems. Another alternative to avoid wrong `FileSystem` could be 
using `SnapshotDirectory(Path, FileSystem)` instead when creating temporary and 
permanent snapshot directories.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to