pnowojski commented on a change in pull request #7688: [FLINK-9816][network]
add option to configure SSL engine provider for TM communication
URL: https://github.com/apache/flink/pull/7688#discussion_r280771141
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java
##########
@@ -386,7 +386,8 @@ public void testCreateSSLEngineFactory() throws Exception {
serverConfig.setString(SecurityOptions.SSL_ALGORITHMS,
"TLS_DHE_RSA_WITH_AES_128_CBC_SHA,TLS_DHE_RSA_WITH_AES_128_CBC_SHA256");
final SSLHandlerFactory serverSSLHandlerFactory =
SSLUtils.createInternalServerSSLEngineFactory(serverConfig);
- final SslHandler sslHandler =
serverSSLHandlerFactory.createNettySSLHandler();
+ // note: a 'null' allocator seems to work here (probably only
because we do not use the ssl engine!)
+ final SslHandler sslHandler =
serverSSLHandlerFactory.createNettySSLHandler(null);
Review comment:
`io.netty.buffer.UnpooledByteBufAllocator#DEFAULT`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
